Include the shim-links-with-button-role.js script from the frontend toolkit #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc. @robinwhittleton @paulmsmith. We should add documentation to the toolkit too. This has been added in alphagov/govuk_frontend_toolkit#310. |
|
I can look at that tomorrow or Wednesday. |
Links styled to look like buttons lack button behaviour. This script will allow them to be triggered with a space key after they’ve been focused, to match standard buttons. By default, this behaviour will only be applied to links with a role of button.
By default, this behaviour will only be applied to links with a role of button. <a class="button" role="button">A button</a> This script will allow them to be triggered with a space key after they’ve been focused, to match standard buttons.
gemmaleigh
force-pushed
the
shim-links-with-aria-role-button
branch
from
cf184ac to
2a775df
Compare
gemmaleigh
changed the title
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include a script from the govuk frontend toolkit to shim anchors with
role="button"to be 'clicked' via the space key.For context, here is the PR adding this script to the govuk_frontend_toolkit.
alphagov/govuk_frontend_toolkit#310